Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1689403002: Update a base_nocompile_test expectation (Closed)

Created:
4 years, 10 months ago by tzik
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a base_nocompile_test expectation DISALLOW_ASSIGN_DIFFERENT_TEYES in base_nocompile_tests has been failing since https://crrev.com/651fa1249144a420 BUG=554299 Committed: https://crrev.com/daa4f5a2fe6a9ed3ceb2b04f6f0a6d59814cb619 Cr-Commit-Position: refs/heads/master@{#375172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/bind_unittest.nc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
tzik
PTAL
4 years, 10 months ago (2016-02-12 07:19:47 UTC) #3
Nico
Rs-lgtm
4 years, 10 months ago (2016-02-12 12:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689403002/1
4 years, 10 months ago (2016-02-12 13:05:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 13:54:46 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:57 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/daa4f5a2fe6a9ed3ceb2b04f6f0a6d59814cb619
Cr-Commit-Position: refs/heads/master@{#375172}

Powered by Google App Engine
This is Rietveld 408576698