Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1689393002: Split flags for media capture from DOM elements (Closed)

Created:
4 years, 10 months ago by emircan
Modified:
4 years, 10 months ago
Reviewers:
esprehn, mcasas
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split flags for media capture from DOM elements We have worked on implementing "Media Capture from DOM Elements" API[0] features behind MediaCaptureFromElement flag. Capture of <canvas> and <video> have different progress and plans at this point. [0] https://www.w3.org/TR/mediacapture-fromelement/#html-canvas-element-media-capture-extensions BUG=524218, 569976 Committed: https://crrev.com/d29a173e1b0aec507a2f8db7ee599bcb98fa7e01 Cr-Commit-Position: refs/heads/master@{#376005}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
emircan
PTAL.
4 years, 10 months ago (2016-02-12 19:25:59 UTC) #6
mcasas
lgtm
4 years, 10 months ago (2016-02-12 20:08:08 UTC) #8
emircan
Ping esprehn@ for OWNERS review.
4 years, 10 months ago (2016-02-17 20:32:12 UTC) #11
esprehn
lgtm
4 years, 10 months ago (2016-02-17 20:48:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689393002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689393002/60001
4 years, 10 months ago (2016-02-17 20:51:08 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 10 months ago (2016-02-17 22:39:17 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:40:15 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d29a173e1b0aec507a2f8db7ee599bcb98fa7e01
Cr-Commit-Position: refs/heads/master@{#376005}

Powered by Google App Engine
This is Rietveld 408576698