Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1689303002: Issue 25385. Set documentation comment for enum constants. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -71 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 17 chunks +15 lines, -41 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +3 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 15 chunks +20 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-11 21:50:03 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-11 21:57:18 UTC) #2
Paul Berry
lgtm
4 years, 10 months ago (2016-02-11 22:35:52 UTC) #3
scheglov
4 years, 10 months ago (2016-02-11 22:37:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9184f3862e335241019b8e4916dd3939e734919f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698