Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: content/shell/browser/layout_test/blink_test_controller.h

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/blink_test_controller.h
diff --git a/content/shell/browser/layout_test/blink_test_controller.h b/content/shell/browser/layout_test/blink_test_controller.h
index 72ddca65dae1f5241239f47479aebb4f9ffbdfc9..6c7132a620bc02b8ad0c026204f5dd4bf4af334b 100644
--- a/content/shell/browser/layout_test/blink_test_controller.h
+++ b/content/shell/browser/layout_test/blink_test_controller.h
@@ -16,7 +16,6 @@
#include "base/synchronization/lock.h"
#include "base/threading/non_thread_safe.h"
#include "build/build_config.h"
-#include "components/test_runner/layout_dump_flags.h"
#include "content/public/browser/bluetooth_chooser.h"
#include "content/public/browser/gpu_data_manager_observer.h"
#include "content/public/browser/notification_observer.h"
@@ -32,6 +31,10 @@
class SkBitmap;
+namespace test_runner {
+struct LayoutDumpFlags;
+}
+
namespace url {
class Origin;
}
@@ -180,7 +183,8 @@ class BlinkTestController : public base::NonThreadSafe,
void OnAudioDump(const std::vector<unsigned char>& audio_dump);
void OnImageDump(const std::string& actual_pixel_hash, const SkBitmap& image);
void OnTextDump(const std::string& dump);
- void OnInitiateLayoutDump(test_runner::LayoutDumpFlags layout_dump_flags);
+ void OnInitiateLayoutDump(
+ const test_runner::LayoutDumpFlags& layout_dump_flags);
void OnLayoutDumpResponse(RenderFrameHost* sender, const std::string& dump);
void OnPrintMessage(const std::string& message);
void OnOverridePreferences(const WebPreferences& prefs);
« no previous file with comments | « components/test_runner/web_test_runner.h ('k') | content/shell/browser/layout_test/blink_test_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698