Serialize parameters visible ranges.

Serialize parameters visible ranges.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6038ea770c52c5c2ba48033b906f146a16110e00

[Paul Berry, 2016-02-11 21:10:39]

lgtm assuming comments are addressed.

https://codereview.chromium.org/1689283002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1689283002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1318: * The length of the visible range.
Add comments explaining that when there is no method body, these values are
zero.

https://codereview.chromium.org/1689283002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1689283002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:4282:
test_executable_param_visibleRange() {
Add tests to verify that visibleLength and visibleOffset are zero in the
following circumstances:
- Parameters of a typedef
- Parameters of a function-typed parameter
- Parameters of a top level function that lacks a body (e.g. because it is
marked "extern")
- Parameters of a method that lacks a body because it is abstract

Also test that visibleLength and visibleOffset are correct if the method body
uses "=>" syntax.

[scheglov, 2016-02-11 22:26:20]

https://codereview.chromium.org/1689283002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1689283002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:4282:
test_executable_param_visibleRange() {
On 2016/02/11 21:10:39, Paul Berry wrote:
> Add tests to verify that visibleLength and visibleOffset are zero in the
> following circumstances:
> - Parameters of a typedef
> - Parameters of a function-typed parameter
> - Parameters of a top level function that lacks a body (e.g. because it is
> marked "extern")
> - Parameters of a method that lacks a body because it is abstract
> 
> Also test that visibleLength and visibleOffset are correct if the method body
> uses "=>" syntax.

Done.

[scheglov, 2016-02-11 22:26:59]

Description was changed from

==========
Serialize parameters visible ranges.

R=paulberry@google.com
BUG=
==========

to

==========
Serialize parameters visible ranges.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6038ea770c52c5c2ba48033b906f146a16110e00
==========

[scheglov, 2016-02-11 22:27:00]

Committed patchset #2 (id:20001) manually as
6038ea770c52c5c2ba48033b906f146a16110e00 (presubmit successful).