Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1689273002: Revert of DevTools: [Console] wrap long strings in console (Closed)

Created:
4 years, 10 months ago by sergeyv
Modified:
4 years, 10 months ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: [Console] wrap long strings in console (patchset #1 id:1 of https://codereview.chromium.org/1681013002/ ) Reason for revert: Huge blocks of text in inline values, scopechainsidebarpane BUG=586256 Original issue's description: > DevTools: [Console] wrap long strings in console > > The "white-space: pre" was introduced in crrev.com/1304033003 to avoid > spaces collapsing. > > The "white-space: pre-wrap" does not collapse spaces and wraps text > if needed. > > BUG=583644 > R=pfeldman, dgozman > > Committed: https://crrev.com/8fa870ed97a19658f438db9b9f5b3548cb47bf4a > Cr-Commit-Position: refs/heads/master@{#374292} TBR=dgozman@chromium.org,pfeldman@chromium.org,lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=583644 Committed: https://crrev.com/085a254e5c3e9a3f9311d63c542ca83d761a1f18 Cr-Commit-Position: refs/heads/master@{#375006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/components/objectValue.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sergeyv
Created Revert of DevTools: [Console] wrap long strings in console
4 years, 10 months ago (2016-02-11 20:38:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689273002/1
4 years, 10 months ago (2016-02-11 20:39:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689273002/1
4 years, 10 months ago (2016-02-11 21:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689273002/1
4 years, 10 months ago (2016-02-11 21:34:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 21:44:55 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:38:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/085a254e5c3e9a3f9311d63c542ca83d761a1f18
Cr-Commit-Position: refs/heads/master@{#375006}

Powered by Google App Engine
This is Rietveld 408576698