Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1689263004: CLI. Always fully parse given target files. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

CLI. Always fully parse given target files. It seems that we have a bug - when we analyze a SDK library during running shared tests, we still parse it dietly so we don't actually validate that bodies are warning-free. And when we attempt to use SDK summary, we again parse a library dietly, but then attempt to apply the full summary using DeclarationResolver, which fails because we fail to bind some elements to not parsed nodes. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/09672f09c6b70f3de798201bccc77e5046a4b04f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-12 06:06:59 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-12 14:48:01 UTC) #2
scheglov
4 years, 10 months ago (2016-02-12 15:02:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09672f09c6b70f3de798201bccc77e5046a4b04f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698