Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: Source/core/svg/SVGViewSpec.cpp

Issue 168923002: Drop [LegacyImplementedInBaseClass] from SVGZoomAndSpan IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Further refactoring Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGViewSpec.h ('k') | Source/core/svg/SVGViewSpec.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGViewSpec.cpp
diff --git a/Source/core/svg/SVGViewSpec.cpp b/Source/core/svg/SVGViewSpec.cpp
index 9db13554a3768037ac91037303cccf5f6e647d12..993d9be54b4d67847f775da05b58c99c6b7f668f 100644
--- a/Source/core/svg/SVGViewSpec.cpp
+++ b/Source/core/svg/SVGViewSpec.cpp
@@ -21,8 +21,6 @@
#include "core/svg/SVGViewSpec.h"
#include "SVGNames.h"
-#include "bindings/v8/ExceptionMessages.h"
-#include "bindings/v8/ExceptionState.h"
#include "core/dom/Document.h"
#include "core/svg/SVGAnimatedTransformList.h"
#include "core/svg/SVGParserUtilities.h"
@@ -46,7 +44,6 @@ const SVGPropertyInfo* SVGViewSpec::transformPropertyInfo()
SVGViewSpec::SVGViewSpec(SVGSVGElement* contextElement)
: m_contextElement(contextElement)
- , m_zoomAndPan(SVGZoomAndPanMagnify)
// Note: We make |viewBox| and |preserveAspectRatio|'s contextElement the target element of SVGViewSpec.
// This contextElement will be only used for keeping this alive from the tearoff.
// SVGSVGElement holds a strong-ref to this SVGViewSpec, so this is kept alive as:
@@ -68,12 +65,6 @@ const AtomicString& SVGViewSpec::transformIdentifier()
return s_identifier;
}
-void SVGViewSpec::setZoomAndPan(unsigned short, ExceptionState& exceptionState)
-{
- // SVGViewSpec and all of its content is read-only.
- exceptionState.throwDOMException(NoModificationAllowedError, ExceptionMessages::readOnly());
-}
-
String SVGViewSpec::preserveAspectRatioString() const
{
return m_preserveAspectRatio->baseValue()->valueAsString();
@@ -137,7 +128,7 @@ void SVGViewSpec::detachContextElement()
void SVGViewSpec::reset()
{
- m_zoomAndPan = SVGZoomAndPanMagnify;
+ resetZoomAndPan();
m_transform.clear();
ASSERT(m_viewBox);
m_viewBox->baseValue()->setValue(FloatRect());
@@ -198,7 +189,7 @@ bool SVGViewSpec::parseViewSpecInternal(const CharType* ptr, const CharType* end
if (ptr >= end || *ptr != '(')
return false;
ptr++;
- if (!parseZoomAndPan(ptr, end, m_zoomAndPan))
+ if (!parseZoomAndPan(ptr, end))
return false;
if (ptr >= end || *ptr != ')')
return false;
« no previous file with comments | « Source/core/svg/SVGViewSpec.h ('k') | Source/core/svg/SVGViewSpec.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698