Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168923002: Drop [LegacyImplementedInBaseClass] from SVGZoomAndSpan IDL interface (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Drop [LegacyImplementedInBaseClass] from SVGZoomAndSpan IDL interface Drop [LegacyImplementedInBaseClass] from SVGZoomAndSpan IDL interface by refactoring the code a little bit. Also have SVGViewSpec implement to SVGZoomAndSpan IDL interface instead of duplicating the SVGZoomAndSpan API. This was done because unlike other interfaces, SVGViewSpec's zoomAndSpan attribute setter raises an exception. However, this can be handled in SVGZoomAndSpan class by overloading the setZoomAndSpan method. R=haraken, pdr BUG=344224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167260

Patch Set 1 #

Patch Set 2 : Update copyright #

Patch Set 3 : Further refactoring #

Patch Set 4 : Further refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -80 lines) Patch
M Source/core/svg/SVGSVGElement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 3 3 chunks +11 lines, -12 lines 0 comments Download
M Source/core/svg/SVGViewElement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGViewElement.cpp View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGViewSpec.h View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 2 5 chunks +2 lines, -11 lines 0 comments Download
M Source/core/svg/SVGViewSpec.idl View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.h View 1 2 3 3 chunks +23 lines, -15 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.cpp View 1 2 3 chunks +20 lines, -17 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.idl View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 10 months ago (2014-02-16 19:34:13 UTC) #1
pdr.
On 2014/02/16 19:34:13, Chris Dumez wrote: LGTM
6 years, 10 months ago (2014-02-16 23:11:17 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-16 23:11:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168923002/110001
6 years, 10 months ago (2014-02-16 23:11:36 UTC) #4
haraken
LGTM
6 years, 10 months ago (2014-02-16 23:15:48 UTC) #5
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 01:30:26 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 01:30:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168923002/110001
6 years, 10 months ago (2014-02-17 01:30:44 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 04:55:18 UTC) #9
Message was sent while issue was closed. 
Change committed as 167260

Powered by Google App Engine
This is Rietveld 408576698