Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1689113003: Revert of Enable asm-wasm mjsunit tests. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Enable asm-wasm mjsunit tests. (patchset #1 id:1 of https://codereview.chromium.org/1687813003/ ) Reason for revert: [Sheriff] Breaks chromebooks with arm: https://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/4397 You can reland, but please keep it skipped for arm. Original issue's description: > Enable asm-wasm mjsunit tests. > > BUG= https://code.google.com/p/v8/issues/detail?id=4203 > TEST=mjsunit/asm-wasm > R=aseemgarg@chromium.org,titzer@chromium.org > LOG=N > > Committed: https://crrev.com/46728d4d9576585bceaa66b8362755c29d3e54bd > Cr-Commit-Position: refs/heads/master@{#33883} TBR=aseemgarg@chromium.org,titzer@chromium.org,bradnelson@google.com,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= https://code.google.com/p/v8/issues/detail?id=4203 Committed: https://crrev.com/82434b1bd1bde3f21745673183b0218b2067788f Cr-Commit-Position: refs/heads/master@{#33905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Michael Achenbach
Created Revert of Enable asm-wasm mjsunit tests.
4 years, 10 months ago (2016-02-11 15:28:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113003/1
4 years, 10 months ago (2016-02-11 15:28:20 UTC) #2
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-11 15:28:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113003/1
4 years, 10 months ago (2016-02-11 15:29:39 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
4 years, 10 months ago (2016-02-11 15:31:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113003/1
4 years, 10 months ago (2016-02-11 15:33:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 15:35:53 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 15:36:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82434b1bd1bde3f21745673183b0218b2067788f
Cr-Commit-Position: refs/heads/master@{#33905}

Powered by Google App Engine
This is Rietveld 408576698