Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1689093004: [CT] Use zips of SKPs to speed up "isolate tests" in recipes (Closed)

Created:
4 years, 10 months ago by rmistry
Modified:
4 years, 10 months ago
Reviewers:
borenet
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[CT] Use zips of SKPs to speed up "isolate tests" in recipes. Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) This change compresses the 1M SKPs into 100 zip files. See related .isolate change in https://codereview.chromium.org/1691023002/ BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298749

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Retrain expectations #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -2 lines) Patch
M scripts/slave/recipes/skia/ct_skps.py View 1 3 chunks +8 lines, -2 lines 2 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_BENCH_10k_SKPs.json View 1 2 5 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs.json View 1 2 5 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_2slaves_failure.json View 1 2 5 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_Trybot.json View 1 2 5 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_slave3_failure.json View 1 2 5 chunks +50 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_1m_SKPs.json View 1 2 5 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
rmistry
4 years, 10 months ago (2016-02-11 20:03:17 UTC) #4
borenet
https://codereview.chromium.org/1689093004/diff/40001/scripts/slave/recipes/skia/ct_skps.py File scripts/slave/recipes/skia/ct_skps.py (right): https://codereview.chromium.org/1689093004/diff/40001/scripts/slave/recipes/skia/ct_skps.py#newcode123 scripts/slave/recipes/skia/ct_skps.py:123: output=skps_dir.join('slave%s.zip' % slave_num)) I'm confused; what's the point of ...
4 years, 10 months ago (2016-02-11 20:11:55 UTC) #5
rmistry
https://codereview.chromium.org/1689093004/diff/40001/scripts/slave/recipes/skia/ct_skps.py File scripts/slave/recipes/skia/ct_skps.py (right): https://codereview.chromium.org/1689093004/diff/40001/scripts/slave/recipes/skia/ct_skps.py#newcode123 scripts/slave/recipes/skia/ct_skps.py:123: output=skps_dir.join('slave%s.zip' % slave_num)) On 2016/02/11 20:11:55, borenet wrote: > ...
4 years, 10 months ago (2016-02-11 20:42:53 UTC) #6
borenet
On 2016/02/11 20:42:53, rmistry wrote: > https://codereview.chromium.org/1689093004/diff/40001/scripts/slave/recipes/skia/ct_skps.py > File scripts/slave/recipes/skia/ct_skps.py (right): > > https://codereview.chromium.org/1689093004/diff/40001/scripts/slave/recipes/skia/ct_skps.py#newcode123 > ...
4 years, 10 months ago (2016-02-11 20:51:28 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689093004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689093004/40001
4 years, 10 months ago (2016-02-11 20:57:45 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 21:01:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689093004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689093004/40001
4 years, 10 months ago (2016-02-11 22:46:56 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298749
4 years, 10 months ago (2016-02-11 22:50:05 UTC) #15
rmistry1
4 years, 10 months ago (2016-02-12 12:03:17 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1695723002/ by rmistry@chromium.org.

The reason for reverting is: The zipping and unzipping process seems to take
longer than the isolate binary did for >100k files. Reverting this experiment.
I am instead going to break up the "isolate tests" steps into multiple steps if
>100k files..

Powered by Google App Engine
This is Rietveld 408576698