Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1689053002: CMakeLists.txt demo (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMakeLists.txt demo - don't require backend headers in SkCodec.cpp - have SkGifCodec disable itself if giflib is too old - disable png filter optimizations if we can't include pngstruct.h Make SkJpegCodec compatible with libjpeg BUG=skia:4520 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1687863003 patch from issue 1687863003 at patchset 40001 (http://crrev.com/1687863003#ps40001) CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot

Patch Set 1 #

Patch Set 2 : builds #

Patch Set 3 : SkCodec.h doesn't need headers. #

Patch Set 4 : move inside gif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -17 lines) Patch
M cmake/CMakeLists.txt View 1 2 3 7 chunks +12 lines, -4 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M public.bzl View 2 chunks +0 lines, -2 lines 0 comments Download
M src/codec/SkCodec.cpp View 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M src/codec/SkGifCodec.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/codec/SkGifCodec.cpp View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 6 chunks +32 lines, -5 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M tools/BUILD.public.expected View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
scroggo
4 years, 10 months ago (2016-02-11 13:49:39 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698