Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1689033003: Switch broken console inspect method to call the _inspect method of the JS inspector host object. (Closed)

Created:
4 years, 10 months ago by Jacob
Modified:
4 years, 10 months ago
Reviewers:
Alan Knight, terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch broken console inspect method to call the _inspect method of the JS inspector host object. BUG= Committed: https://github.com/dart-lang/sdk/commit/c0ddc73fce9f315ec2b4f48f0c02d9069553f1c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
corresponding Dart cl for blink CL already landed.
4 years, 10 months ago (2016-02-11 02:49:10 UTC) #2
Jacob
TBR
4 years, 10 months ago (2016-02-11 02:49:17 UTC) #3
Jacob
Committed patchset #1 (id:1) manually as c0ddc73fce9f315ec2b4f48f0c02d9069553f1c9.
4 years, 10 months ago (2016-02-11 02:49:31 UTC) #5
Alan Knight
4 years, 10 months ago (2016-02-11 19:08:09 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698