Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 168903005: Ensure that RSA signatures have the correct length (Closed)

Created:
6 years, 10 months ago by bartfab (slow)
Modified:
6 years, 10 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Ensure that RSA signatures have the correct length TLS Lite generates RSA signatures by converting a large integer that holds the signature to a byte string. It does not apply any padding so that if the signature starts with sufficiently many zero bits, the byte string will be shorter than expected (it should have the same length as the key's modulus). This bug was fixed in trunk TLS Lite but is still present in our fork. The fix in trunk TLS Lite was spread over two commits: * Add a |howManyBytes| argument to the numberToBytes() method: https://github.com/trevp/tlslite/commit/ 4278f558c2c519684ab35e9fc84887c15a11ea16 * Specify |howManyBytes| when generating an RSA signature: https://github.com/trevp/tlslite/commit/ 0b8b2b4122109f22900ec929432308dd685f1d45 BUG=331761 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251797

Patch Set 1 : #

Patch Set 2 : Small correction to README.chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M third_party/tlslite/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/tlslite/patches/rsa_signature_length.patch View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/utils/RSAKey.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tlslite/tlslite/utils/cryptomath.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
bartfab (slow)
Hi Ryan, Could you please review?
6 years, 10 months ago (2014-02-18 14:20:29 UTC) #1
bartfab (slow)
Hi Adam, Could you take a look?
6 years, 10 months ago (2014-02-18 14:31:58 UTC) #2
agl
lgtm
6 years, 10 months ago (2014-02-18 14:34:28 UTC) #3
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 10 months ago (2014-02-18 14:34:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/168903005/60002
6 years, 10 months ago (2014-02-18 14:34:59 UTC) #5
bartfab (slow)
The CQ bit was unchecked by bartfab@chromium.org
6 years, 10 months ago (2014-02-18 14:35:12 UTC) #6
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 10 months ago (2014-02-18 14:37:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/168903005/220001
6 years, 10 months ago (2014-02-18 14:37:27 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 15:36:24 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265570
6 years, 10 months ago (2014-02-18 15:36:24 UTC) #10
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 10 months ago (2014-02-18 15:37:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/168903005/220001
6 years, 10 months ago (2014-02-18 15:37:35 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 18:11:00 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-18 18:11:01 UTC) #14
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 10 months ago (2014-02-18 18:38:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/168903005/220001
6 years, 10 months ago (2014-02-18 18:38:43 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 18:39:39 UTC) #17
Message was sent while issue was closed.
Change committed as 251797

Powered by Google App Engine
This is Rietveld 408576698