Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1688953002: Mac: Suppress asserts about resources being in use (Closed)

Created:
4 years, 10 months ago by ccameron
Modified:
4 years, 10 months ago
Reviewers:
David Yen
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Suppress asserts about resources being in use This papers over the asserts that are occurring on the trybots by changing the failing DCHECKs to not fail the reason for the failure was IOSurfaceIsInUse returning YES unexpectedly. This lets the asserts stay (mostly, completely on non-Mac platforms) in place, but un-breaks the tryservers. BUG=577121 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/60d756a6b3daaf8e579bc8464f8cf72f0cb090f3 Cr-Commit-Position: refs/heads/master@{#374786}

Patch Set 1 #

Patch Set 2 : Add missed function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M cc/resources/resource_pool.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ccameron
More spiralling out of control of this ...
4 years, 10 months ago (2016-02-10 21:49:53 UTC) #3
David Yen
LGTM, do we have any ideas what could be going wrong here?
4 years, 10 months ago (2016-02-10 21:59:31 UTC) #4
ccameron
Thanks. Still no -- never got a repro.
4 years, 10 months ago (2016-02-10 22:04:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688953002/20001
4 years, 10 months ago (2016-02-10 22:18:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 23:43:06 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60d756a6b3daaf8e579bc8464f8cf72f0cb090f3
Cr-Commit-Position: refs/heads/master@{#374786}

Powered by Google App Engine
This is Rietveld 408576698