Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1688913002: [Autofill] Moving the LICENSE file in preparation for DEPS change (Closed)

Created:
4 years, 10 months ago by Mathieu
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Moving the LICENSE file in preparation for DEPS change Upcoming DEPS change in https://codereview.chromium.org/1674373003/ conflicts with this file. BUG=585286 Committed: https://crrev.com/617584e8ef08e842f611e7db7332610f16f1b9a3 Cr-Commit-Position: refs/heads/master@{#374720}

Patch Set 1 #

Patch Set 2 : moved to libphonenumber/ #

Patch Set 3 : updated license #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
A + third_party/libphonenumber/LICENSE View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/libphonenumber/README.chromium View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/libphonenumber/src/LICENSE View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Mathieu
PTAL
4 years, 10 months ago (2016-02-10 20:14:39 UTC) #2
please use gerrit instead
Let's move it up a dir instead.
4 years, 10 months ago (2016-02-10 20:18:29 UTC) #3
please use gerrit instead
Update README.chromium's pointer to the license file, please.
4 years, 10 months ago (2016-02-10 20:20:15 UTC) #5
please use gerrit instead
https://codereview.chromium.org/1688913002/diff/40001/third_party/libphonenumber/README.chromium File third_party/libphonenumber/README.chromium (right): https://codereview.chromium.org/1688913002/diff/40001/third_party/libphonenumber/README.chromium#newcode7 third_party/libphonenumber/README.chromium:7: License File: src/LICENSE Remove "src/"
4 years, 10 months ago (2016-02-10 20:23:28 UTC) #6
please use gerrit instead
lgtm after removing "src/" from LICENSE.
4 years, 10 months ago (2016-02-10 20:24:03 UTC) #7
Mathieu
https://codereview.chromium.org/1688913002/diff/40001/third_party/libphonenumber/README.chromium File third_party/libphonenumber/README.chromium (right): https://codereview.chromium.org/1688913002/diff/40001/third_party/libphonenumber/README.chromium#newcode7 third_party/libphonenumber/README.chromium:7: License File: src/LICENSE On 2016/02/10 20:23:28, Rouslan wrote: > ...
4 years, 10 months ago (2016-02-10 20:24:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688913002/60001
4 years, 10 months ago (2016-02-10 20:27:12 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-10 21:10:49 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:58 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/617584e8ef08e842f611e7db7332610f16f1b9a3
Cr-Commit-Position: refs/heads/master@{#374720}

Powered by Google App Engine
This is Rietveld 408576698