Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688883002: Suppressions for Dartium 45 roll (Closed)

Created:
4 years, 10 months ago by Alan Knight
Modified:
4 years, 10 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -0 lines) Patch
M tests/co19/co19-dartium.status View 1 chunk +110 lines, -0 lines 2 comments Download
M tests/html/html.status View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Alan Knight
TBR
4 years, 10 months ago (2016-02-10 19:30:59 UTC) #2
Alan Knight
Committed patchset #1 (id:1) manually as 1fe4654d6b74c36d164ad02cbc89ba257da7b597 (presubmit successful).
4 years, 10 months ago (2016-02-10 19:31:46 UTC) #4
Jacob
https://codereview.chromium.org/1688883002/diff/1/tests/co19/co19-dartium.status File tests/co19/co19-dartium.status (right): https://codereview.chromium.org/1688883002/diff/1/tests/co19/co19-dartium.status#newcode1335 tests/co19/co19-dartium.status:1335: LayoutTests/fast/canvas/alpha_t01: RuntimeError # Dartium 45 roll These need their ...
4 years, 10 months ago (2016-02-10 20:08:02 UTC) #5
Alan Knight
4 years, 10 months ago (2016-02-10 20:25:33 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1688883002/diff/1/tests/co19/co19-dartium.status
File tests/co19/co19-dartium.status (right):

https://codereview.chromium.org/1688883002/diff/1/tests/co19/co19-dartium.sta...
tests/co19/co19-dartium.status:1335: LayoutTests/fast/canvas/alpha_t01:
RuntimeError # Dartium 45 roll
On 2016/02/10 20:08:01, Jacob wrote:
> These need their own bug #. The fact that we have broken the JavaScript canvas
> and css tests is very concerning.

Issue number added in separate CL.

These aren't the JavaScript tests, they're ported Dart versions of same.

https://codereview.chromium.org/1688883002/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/1688883002/diff/1/tests/html/html.status#newc...
tests/html/html.status:21: blob_constructor_test: RuntimeError # Dartium 45 roll
On 2016/02/10 20:08:01, Jacob wrote:
> These need a bug #. The bug can just reference the 45 roll.

Done.

Powered by Google App Engine
This is Rietveld 408576698