Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688863002: Remove DEPRECATED_java_in_dir from junit and mockito BUILD.gn. (Closed)

Created:
4 years, 10 months ago by mikecase (-- gone --)
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DEPRECATED_java_in_dir from junit and mockito BUILD.gn. BUG= Committed: https://crrev.com/f271b536b07eaf8c9107e3841c249eb07092e0e8 Cr-Commit-Position: refs/heads/master@{#374708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -2 lines) Patch
M third_party/junit/BUILD.gn View 1 chunk +164 lines, -1 line 0 comments Download
M third_party/mockito/BUILD.gn View 1 chunk +314 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mikecase (-- gone --)
Given the name of the variable, I'm guessing we were supposed to remove DEPRECATED_java_in_dir at ...
4 years, 10 months ago (2016-02-10 18:21:58 UTC) #2
jbudorick
lgtm
4 years, 10 months ago (2016-02-10 18:23:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688863002/1
4 years, 10 months ago (2016-02-10 18:26:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 20:14:15 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f271b536b07eaf8c9107e3841c249eb07092e0e8
Cr-Commit-Position: refs/heads/master@{#374708}

Powered by Google App Engine
This is Rietveld 408576698