Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1688803005: Revert of [regexp] ship unicode regexps. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
rossberg, Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] ship unicode regexps. (patchset #1 id:1 of https://codereview.chromium.org/1689113002/ ) Reason for revert: [Sheriff] Speculative revert for gc stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/1726 Blamelists are screwed up currently... Original issue's description: > [regexp] ship unicode regexps. > > R=rossberg@chromium.org > BUG=v8:2952 > LOG=N > > Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 > Cr-Commit-Position: refs/heads/master@{#33899} TBR=rossberg@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2952 Committed: https://crrev.com/699e1081a658ff62df6df1efe7db2b250111dedd Cr-Commit-Position: refs/heads/master@{#33902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/no-unicode-regexp-flag.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
Created Revert of [regexp] ship unicode regexps.
4 years, 10 months ago (2016-02-11 14:57:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803005/1
4 years, 10 months ago (2016-02-11 14:57:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 14:58:18 UTC) #4
Yang
On 2016/02/11 14:58:18, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) lgtm. ...
4 years, 10 months ago (2016-02-11 15:00:21 UTC) #5
Michael Achenbach
On 2016/02/11 15:00:21, Yang wrote: > On 2016/02/11 14:58:18, commit-bot: I haz the power wrote: ...
4 years, 10 months ago (2016-02-11 15:07:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/699e1081a658ff62df6df1efe7db2b250111dedd Cr-Commit-Position: refs/heads/master@{#33902}
4 years, 10 months ago (2016-02-11 15:14:44 UTC) #8
Michael Achenbach
4 years, 10 months ago (2016-02-11 20:40:44 UTC) #9
Message was sent while issue was closed.
A thing I don't quite understand yet: This revert caused this:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20...

But it didn't happen before the original CL landed. So maybe something that
changed in between helped triggering this error.

Powered by Google App Engine
This is Rietveld 408576698