Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 16888013: Revert "Initial implementation of on-stack replacement (OSR)." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 2f9283836fa0cddf469bf0b5de0a5e3646e7e99f..3f043e3719a4b9f3ffef585fdfc3e754b3cd1a2e 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -23,7 +23,6 @@ namespace dart {
DECLARE_FLAG(int, optimization_counter_threshold);
DECLARE_FLAG(bool, propagate_ic_data);
-DECLARE_FLAG(bool, use_osr);
// Generic summary for call instructions that have all arguments pushed
// on the stack and return the result in a fixed register EAX.
@@ -2117,13 +2116,6 @@ class CheckStackOverflowSlowPath : public SlowPathCode {
instruction_->deopt_id(),
kStackOverflowRuntimeEntry,
instruction_->locs());
-
- if (FLAG_use_osr && !compiler->is_optimizing() && instruction_->in_loop()) {
- // In unoptimized code, record loop stack checks as possible OSR entries.
- compiler->AddCurrentDescriptor(PcDescriptors::kOsrEntry,
- instruction_->deopt_id(),
- 0); // No token position.
- }
compiler->pending_deoptimization_env_ = NULL;
compiler->RestoreLiveRegisters(instruction_->locs());
__ jmp(exit_label());
@@ -2141,14 +2133,6 @@ void CheckStackOverflowInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ cmpl(ESP,
Address::Absolute(Isolate::Current()->stack_limit_address()));
__ j(BELOW_EQUAL, slow_path->entry_label());
- if (FLAG_use_osr && !compiler->is_optimizing() && in_loop()) {
- // In unoptimized code check the usage counter to trigger OSR at loop
- // stack checks.
- __ LoadObject(EDI, compiler->parsed_function().function());
- __ cmpl(FieldAddress(EDI, Function::usage_counter_offset()),
- Immediate(2 * FLAG_optimization_counter_threshold));
- __ j(GREATER_EQUAL, slow_path->entry_label());
- }
__ Bind(slow_path->exit_label());
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698