Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: Source/core/dom/Text.cpp

Issue 16888008: Don't create renderers for whitespace nodes in flexbox (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/platform/linux/fast/forms/button-default-title-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 return false; 204 return false;
205 205
206 if (context.style()->display() == NONE) 206 if (context.style()->display() == NONE)
207 return false; 207 return false;
208 208
209 bool onlyWS = containsOnlyWhitespace(); 209 bool onlyWS = containsOnlyWhitespace();
210 if (!onlyWS) 210 if (!onlyWS)
211 return true; 211 return true;
212 212
213 RenderObject* parent = context.parentRenderer(); 213 RenderObject* parent = context.parentRenderer();
214 if (parent->isTable() || parent->isTableRow() || parent->isTableSection() || parent->isRenderTableCol() || parent->isFrameSet()) 214 if (parent->isTable() || parent->isTableRow() || parent->isTableSection() || parent->isRenderTableCol() || parent->isFrameSet()
215 || parent->isFlexibleBox() || parent->isRenderGrid())
215 return false; 216 return false;
216 217
217 if (context.style()->preserveNewline()) // pre/pre-wrap/pre-line always make renderers. 218 if (context.style()->preserveNewline()) // pre/pre-wrap/pre-line always make renderers.
218 return true; 219 return true;
219 220
220 RenderObject* prev = context.previousRenderer(); 221 RenderObject* prev = context.previousRenderer();
221 if (prev && prev->isBR()) // <span><br/> <br/></span> 222 if (prev && prev->isBR()) // <span><br/> <br/></span>
222 return false; 223 return false;
223 224
224 if (parent->isRenderInline()) { 225 if (parent->isRenderInline()) {
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 result.appendLiteral("; "); 342 result.appendLiteral("; ");
342 result.appendLiteral("value="); 343 result.appendLiteral("value=");
343 result.append(s); 344 result.append(s);
344 } 345 }
345 346
346 strncpy(buffer, result.toString().utf8().data(), length - 1); 347 strncpy(buffer, result.toString().utf8().data(), length - 1);
347 } 348 }
348 #endif 349 #endif
349 350
350 } // namespace WebCore 351 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/platform/linux/fast/forms/button-default-title-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698