Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: build/landmines.py

Issue 16888005: Add landmine for win x64 trybots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/landmines.py
diff --git a/build/landmines.py b/build/landmines.py
index 40177eadd7affdce00bab46e38fd9696f55ed25e..eaaca465172695f37829a331f342a1a1246146f2 100755
--- a/build/landmines.py
+++ b/build/landmines.py
@@ -66,6 +66,10 @@ def gyp_defines():
return dict(arg.split('=', 1)
for arg in shlex.split(os.environ.get('GYP_DEFINES', '')))
+@memoize()
+def gyp_msvs_version():
+ val = os.environ.get('GYP_MSVS_VERSION', '')
+ return int(val) if val else None
@memoize()
def distributor():
@@ -149,6 +153,11 @@ def get_landmines(target):
add('Builders switching from make to ninja will clobber on this.')
if platform() == 'mac':
add('Switching from bundle to unbundled dylib (issue 14743002).')
+ if (platform() == 'win' and builder() == 'ninja' and
+ gyp_msvs_version() == 2012 and
+ gyp_defines().get('target_arch') == 'x64' and
+ gyp_defines().get('dcheck_always_on') == '1'):
+ add("Switched win x64 trybots from VS2010 to VS2012.")
return landmines
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698