Issue 16888005: Add landmine for win x64 trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16888005: Add landmine for win x64 trybots. (Closed)

Created:
7 years, 6 months ago by iannucci

Modified:
7 years, 6 months ago

Reviewers:
agable

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add landmine for win x64 trybots. TBR=agable@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205997

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	build/landmines.py	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

agable

On 2013/06/13 03:41:33, iannucci wrote: > Committed patchset #1 manually as r205997. LGTM

7 years, 6 months ago (2013-06-13 16:12:32 UTC) #3

scottmg

On 2013/06/13 16:12:32, Aaron Gable wrote: > On 2013/06/13 03:41:33, iannucci wrote: > > Committed ...

7 years, 6 months ago (2013-06-13 16:44:21 UTC) #4

iannucci

7 years, 6 months ago (2013-06-13 18:25:12 UTC) #5

Message was sent while issue was closed.

On 2013/06/13 16:44:21, scottmg wrote:
> On 2013/06/13 16:12:32, Aaron Gable wrote:
> > On 2013/06/13 03:41:33, iannucci wrote:
> > > Committed patchset #1 manually as r205997.
> > 
> > LGTM
> 
> This doesn't work on VS Express, "2010e" and "2012e" (which includes
>
http://www.chromium.org/developers/how-tos/build-instructions-windows#TOC-Aut...)

Fix incoming in https://codereview.chromium.org/16978002/

Expand Messages | Collapse Messages