Fix shutdown race when running Dart on the message loop

Fix shutdown race when running Dart on the message loop

- Shutdown the DartController when the content handler exits not when the content handler's message loop hits an error (which occurs when the final application closes its shell handle.)

Other fixes:

- DartMessageHandler considers the isolate as exited if it hit an unhandled exception error.
- DartMessageHandler can be configured to not quit the message loop when the isolate exits.

R=zra@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/27d0e88f9491c00c039a930683685dbcd1e75122

[Cutch, 2016-02-10 15:50:42]

Description was changed from

==========
Fix shutdown errors when running Dart on the message loop

BUG=
==========

to

==========
Fix shutdown race when running Dart on the message loop

BUG=
==========

[Cutch, 2016-02-10 15:54:42]

Description was changed from

==========
Fix shutdown race when running Dart on the message loop

BUG=
==========

to

==========
Fix shutdown race when running Dart on the message loop

- Shutdown the DartController when the content handler exits not when the
content handler's message loop hits an error (which occurs when the final
application closes it's shell handle.)

Other fixes:

- DartMessageHandler considers the isolate as exited if it hit an unhandled
exception error.
- DartMessageHandler can be configured to not quit the message loop when the
isolate exits.
==========

[Cutch, 2016-02-10 15:54:42]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[Cutch, 2016-02-10 15:55:19]

Description was changed from

==========
Fix shutdown race when running Dart on the message loop

- Shutdown the DartController when the content handler exits not when the
content handler's message loop hits an error (which occurs when the final
application closes it's shell handle.)

Other fixes:

- DartMessageHandler considers the isolate as exited if it hit an unhandled
exception error.
- DartMessageHandler can be configured to not quit the message loop when the
isolate exits.
==========

to

==========
Fix shutdown race when running Dart on the message loop

- Shutdown the DartController when the content handler exits not when the
content handler's message loop hits an error (which occurs when the final
application closes its shell handle.)

Other fixes:

- DartMessageHandler considers the isolate as exited if it hit an unhandled
exception error.
- DartMessageHandler can be configured to not quit the message loop when the
isolate exits.
==========

[zra, 2016-02-10 16:02:51]

lgtm

[Cutch, 2016-02-10 16:40:31]

Description was changed from

==========
Fix shutdown race when running Dart on the message loop

- Shutdown the DartController when the content handler exits not when the
content handler's message loop hits an error (which occurs when the final
application closes its shell handle.)

Other fixes:

- DartMessageHandler considers the isolate as exited if it hit an unhandled
exception error.
- DartMessageHandler can be configured to not quit the message loop when the
isolate exits.
==========

to

==========
Fix shutdown race when running Dart on the message loop

- Shutdown the DartController when the content handler exits not when the
content handler's message loop hits an error (which occurs when the final
application closes its shell handle.)

Other fixes:

- DartMessageHandler considers the isolate as exited if it hit an unhandled
exception error.
- DartMessageHandler can be configured to not quit the message loop when the
isolate exits.

R=zra@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/27d0e88f9491c00c039a9306836...
==========

[Cutch, 2016-02-10 16:40:32]

Committed patchset #2 (id:20001) manually as
27d0e88f9491c00c039a930683685dbcd1e75122 (presubmit successful).

[tonyg, 2016-02-10 17:27:36]

On 2016/02/10 16:40:32, Cutch wrote:
> Committed patchset #2 (id:20001) manually as
> 27d0e88f9491c00c039a930683685dbcd1e75122 (presubmit successful).

The bots we're so happy w/ this change.

[jamesr, 2016-02-10 17:53:36]

On 2016/02/10 at 17:27:36, tonyg wrote:
> On 2016/02/10 16:40:32, Cutch wrote:
> > Committed patchset #2 (id:20001) manually as
> > 27d0e88f9491c00c039a930683685dbcd1e75122 (presubmit successful).
> 
> The bots we're so happy w/ this change.

The bot failures look like infra issues, not related to this:


________ running '/usr/bin/python src/build/landmines.py' in
'/mnt/data/b/build/slave/mojo/build'

________ running '/usr/bin/python src/tools/clang/scripts/update.py --if-needed'
in '/mnt/data/b/build/slave/mojo/build'
Clang already at 247874-1

________ running '/usr/bin/python src/tools/dart/update.py' in
'/mnt/data/b/build/slave/mojo/build'
Running ['unzip', '-o', '-q',
'/mnt/data/b/build/slave/mojo/build/src/third_party/dart-sdk/dartsdk-linux-x64-release.zip',
'-d', '/mnt/data/b/build/slave/mojo/build/src/third_party/dart-sdk']

________ running '/usr/bin/python src/tools/android/download_android_tools.py'
in '/mnt/data/b/build/slave/mojo/build'
Traceback (most recent call last):
  File "src/tools/android/download_android_tools.py", line 26, in <module>
    import find_depot_tools
  File "/mnt/data/b/build/slave/mojo/build/src/tools/find_depot_tools.py", line
45, in <module>
    import breakpad
ImportError: No module named breakpad
Error: Command '/usr/bin/python src/tools/android/download_android_tools.py'
returned non-zero exit status 1 in /mnt/data/b/build/slave/mojo/build
step returned non-zero exit code: 2
@@@STEP_FAILURE@@@

[jamesr, 2016-02-10 21:31:09]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2016-02-10 21:31:10]

There are now some newer failures that do look related:

https://build.chromium.org/p/client.mojo/builders/Mojo%20Linux%20ASan/builds/...


Unhandled exception:
Dummy exception to set exit code.
#0      _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:895)
#1      _microtaskLoop (dart:async/schedule_microtask.dart:41)
#2      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#3      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:394)
#4      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:414)
#5      _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:148)
Traceback (most recent call last):
  File "examples/dart/example_tests.py", line 59, in <module>
    sys.exit(main(args.build_dir, package_root))
  File "examples/dart/example_tests.py", line 46, in main
    RunTests(tests, build_dir, package_root)
  File "examples/dart/example_tests.py", line 41, in RunTests
    '--mojo-shell', os.path.join(build_dir, 'mojo_shell'),])
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command
'['/b/build/slave/mojo/build/src/third_party/dart-sdk/dart-sdk/bin/dart', '-p',
'/b/build/slave/mojo/build/src/out/Release_asan/gen/dart-pkg/packages',
'--checked',
'/b/build/slave/mojo/build/src/examples/dart/wget/test/wget_test.dart',
'--mojo-shell', 'out/Release_asan/mojo_shell']' returned non-zero exit status
255
00:00 +0: Hello, .mojo!
00:00 +1: Hello, .dart!
00:01 +2: All tests passed!
00:00 +0: Wget .mojo
00:30 +0 -1: Wget .mojo
  TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
  dart:isolate  _RawReceivePortImpl._handleMessage

00:30 +0 -1: Wget .dart
00:31 +1 -1: Some tests failed.

step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

also looks flaky