Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1688783005: Reland of [counters] moving runtime counters to counter.h (Closed)

Created:
4 years, 10 months ago by Camillo Bruni
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [counters] moving runtime counters to counter.h (patchset #1 id:1 of https://codereview.chromium.org/1681923003/ ) Reason for revert: This CL was not the cause for the TSAN failures, the instruction-selector backend for x64 emitted a wrong compare which accidentally showed up with tsan + code moves. The instruction-selectors changes have been reverted with https://codereview.chromium.org/1693433002 Original issue's description: > Revert of [counters] moving runtime counters to counter.h (patchset #1 id:1 of https://codereview.chromium.org/1678973002/ ) > > Reason for revert: > [Sheriff] Breaks TSAN: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7727 > > Original issue's description: > > [counters] moving runtime counters to counter.h > > > > Additionally list C++ builtins as well under --runtime_call_stats. > > Let's try to keep all counters in one place, that makes it a bit > > easier to maintain and especially discard unused ones. > > > > BUG= > > > > Committed: https://crrev.com/6bc71431995d49d4ca4a2ea9c75e5add5f345225 > > Cr-Commit-Position: refs/heads/master@{#33847} > > TBR=jarin@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/2d669b96639517cfc33e6fc6d4c3814587bc7366 > Cr-Commit-Position: refs/heads/master@{#33848} TBR=jarin@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/ad943fe44ede22b90b871e1233334dff5ff545c3 Cr-Commit-Position: refs/heads/master@{#33887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -128 lines) Patch
M src/arguments.h View 1 chunk +22 lines, -24 lines 0 comments Download
M src/builtins.cc View 1 chunk +17 lines, -1 line 0 comments Download
M src/counters.h View 4 chunks +29 lines, -0 lines 0 comments Download
M src/counters.cc View 2 chunks +101 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/runtime/runtime.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Camillo Bruni
Created Reland of [counters] moving runtime counters to counter.h
4 years, 10 months ago (2016-02-11 10:47:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688783005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688783005/1
4 years, 10 months ago (2016-02-11 10:47:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 11:13:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 11:14:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ad943fe44ede22b90b871e1233334dff5ff545c3 Cr-Commit-Position: refs/heads/master@{#33887}
4 years, 10 months ago (2016-02-11 11:14:10 UTC) #7
Camillo Bruni
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1687313002/ by cbruni@chromium.org. ...
4 years, 10 months ago (2016-02-11 11:56:04 UTC) #8
Michael Achenbach
4 years, 10 months ago (2016-02-11 12:03:38 UTC) #9
Message was sent while issue was closed.
I don't think revert was necessary. At least the failures on gc stress mac are
infra related.

Powered by Google App Engine
This is Rietveld 408576698