Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1688783002: Better view for build_repo_real_try recipe. (Closed)

Created:
4 years, 10 months ago by tandrii(chromium)
Modified:
4 years, 10 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M scripts/slave/recipes/infra/build_repo_real_try.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/infra/build_repo_real_try.expected/ok-outer.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/build_repo_real_try.expected/ok-outer-try.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688783002/1
4 years, 10 months ago (2016-02-10 15:40:00 UTC) #2
tandrii(chromium)
This is based on machenbach@ idea - end result will be much more readable, but ...
4 years, 10 months ago (2016-02-10 15:40:38 UTC) #3
martiniss
lgtm
4 years, 10 months ago (2016-02-10 15:42:53 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 15:42:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298708

Powered by Google App Engine
This is Rietveld 408576698