Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/client/linux/minidump_writer/linux_dumper.cc

Issue 1688743002: Switch the Linux minidump writer to use MDCVInfoELF for CV data. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Rework to handle arbitrary size build ids Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/client/linux/minidump_writer/linux_dumper.cc
diff --git a/src/client/linux/minidump_writer/linux_dumper.cc b/src/client/linux/minidump_writer/linux_dumper.cc
index 060e6c7c0ad5041dd5be011ceb961d887ffc0875..31590c4d8cede01a81ae615b1a6c18d110956533 100644
--- a/src/client/linux/minidump_writer/linux_dumper.cc
+++ b/src/client/linux/minidump_writer/linux_dumper.cc
@@ -121,9 +121,8 @@ bool
LinuxDumper::ElfFileIdentifierForMapping(const MappingInfo& mapping,
bool member,
unsigned int mapping_id,
- uint8_t identifier[sizeof(MDGUID)]) {
+ wasteful_vector<uint8_t>& identifier) {
assert(!member || mapping_id < mappings_.size());
- my_memset(identifier, 0, sizeof(MDGUID));
if (IsMappedFileOpenUnsafe(mapping))
return false;
@@ -138,7 +137,8 @@ LinuxDumper::ElfFileIdentifierForMapping(const MappingInfo& mapping,
reinterpret_cast<const void*>(mapping.start_addr),
mapping.size);
}
- return FileID::ElfFileIdentifierFromMappedFile(linux_gate, identifier);
+ return FileID::ElfFileIdentifierFromMappedFile(linux_gate,
+ identifier);
}
char filename[PATH_MAX];
@@ -151,7 +151,8 @@ LinuxDumper::ElfFileIdentifierForMapping(const MappingInfo& mapping,
return false;
bool success =
- FileID::ElfFileIdentifierFromMappedFile(mapped_file.data(), identifier);
+ FileID::ElfFileIdentifierFromMappedFile(mapped_file.data(),
+ identifier);
if (success && member && filename_modified) {
mappings_[mapping_id]->name[my_strlen(mapping.name) -
sizeof(kDeletedSuffix) + 1] = '\0';
« no previous file with comments | « src/client/linux/minidump_writer/linux_dumper.h ('k') | src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698