Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1688683003: Clear up confusion between type arguments and type parameters in summary tests (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clear up confusion between type arguments and type parameters in summary tests R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/cd94acd7e23db3342589d46512a78ab3e00bb57a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pkg/analyzer/test/src/summary/summary_common.dart View 9 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-10 21:49:43 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-10 21:54:00 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-10 22:14:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd94acd7e23db3342589d46512a78ab3e00bb57a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698