Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1688623002: Don't enable CHROMIUM_ycbcr_420v_image when using mesa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index d8edc1f7f5a5063d94bfea3c2650f8d3cd7cb58d..0223abaa120d777389403bbb5df041056881c4f3 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -1004,8 +1004,10 @@ void FeatureInfo::InitializeFeatures() {
#if defined(OS_MACOSX)
AddExtensionString("GL_CHROMIUM_iosurface");
- AddExtensionString("GL_CHROMIUM_ycbcr_420v_image");
- feature_flags_.chromium_image_ycbcr_420v = true;
+ if (gfx::GetGLImplementation() != gfx::kGLImplementationOSMesaGL) {
reveman 2016/02/10 03:12:14 should GL_CHROMIUM_iosurface also be moved inside
Daniele Castagna 2016/02/10 03:14:56 Sure, IIRC you mentioned GL_CHROMIUM_iosurface is
Daniele Castagna 2016/02/10 03:41:36 Moved AddExtensionString("GL_CHROMIUM_iosurface")
+ AddExtensionString("GL_CHROMIUM_ycbcr_420v_image");
+ feature_flags_.chromium_image_ycbcr_420v = true;
+ }
#endif
if (extensions.Contains("GL_APPLE_ycbcr_422")) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698