Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl

Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
index 711f643d8abf0b0bf436b74a237ab53cd30c09a0..7fb2ac5e728c54270a1412251dc6d958daa2ed8f 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
@@ -5,7 +5,11 @@
// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworkermessage-event-interface
[
- Constructor(DOMString type, optional ServiceWorkerMessageEventInit eventInitDict),
+ // TODO(bashi): Stop using CostomConstructor once we solve reference
nhiroki 2016/02/10 03:44:17 s/Costom/Custom/
bashi 2016/02/10 04:43:38 Done.
+ // circulation between Blink and V8. http://crbug.com/529941
nhiroki 2016/02/10 03:44:17 Apparently, this issue was already fixed. Should w
bashi 2016/02/10 04:43:38 Thanks for the catch. It should be http://crbug.co
+ // Constructor should be:
+ // Constructor(DOMString type, optional ServiceWorkerMessageEventInit eventInitDict),
+ CustomConstructor,
Exposed=(Window, Worker),
] interface ServiceWorkerMessageEvent : Event {
[Custom=Getter] readonly attribute any data;

Powered by Google App Engine
This is Rietveld 408576698