Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1688493003: Revert "Added a switch to dump minidump modules in minidump_stackwalk." (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
David Yen
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Added a switch to dump minidump modules in minidump_stackwalk." This reverts commit cb936a0243c97ae9cd2d4bb19d95dde0421fed6d. A=dyen@chromium.org Original Review: https://codereview.chromium.org/1672773002/ R=dyen@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/a1d84b2da914f62fb1ca897521bbaa9d8810698d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -30 lines) Patch
M src/processor/minidump_stackwalk.cc View 6 chunks +5 lines, -20 lines 0 comments Download
M src/processor/stackwalk_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/processor/stackwalk_common.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 10 months ago (2016-02-10 20:54:34 UTC) #2
David Yen
thanks you, lgtm.
4 years, 10 months ago (2016-02-10 21:10:48 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-10 21:11:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a1d84b2da914f62fb1ca897521bbaa9d8810698d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698