Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1688493002: Fix NPE in completion contributor (issue 25711) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

The exception occurs because the type can be set to `null` if the element is either a parameter or local variable element. This might be a change since the time this code was originally written. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/bcaedf2b7fbbbb173c47805bbfa3e669d573f673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-09 21:05:07 UTC) #3
danrubel
lgtm
4 years, 10 months ago (2016-02-10 17:48:20 UTC) #4
Brian Wilkerson
4 years, 10 months ago (2016-02-10 18:49:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bcaedf2b7fbbbb173c47805bbfa3e669d573f673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698