Revert of Clean up public interface of AttachmentBrokerUnprivileged.

Revert of  Clean up public interface of AttachmentBrokerUnprivileged. (patchset #4 id:80001 of https://codereview.chromium.org/1679763002/ )

Reason for revert:
c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error C2065: 'attachment_broker_' : undeclared identifier

http://build.chromium.org/p/chromium/builders/Win/builds/40168

Original issue's description:
> Clean up public interface of AttachmentBrokerUnprivileged.
>
> In the old interface, a static factory method returns a scoped_ptr, and the
> caller had to manage the lifetime. Since this is a global object with minimal
> memory footprint, and is required to outlive every IPC::Channel, it's much
> easier for the global to never be destroyed. This also matches the interface for
> AttachmentBrokerPrivileged.
>
> BUG=584297
TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584297
Committed: https://crrev.com/4a1261e7d45256df422494a8f94289dfb57a5dbf
Cr-Commit-Position: refs/heads/master@{#374771}

[erikchen, 2016-02-10 23:08:38]

Created Revert of  Clean up public interface of AttachmentBrokerUnprivileged.

[commit-bot: I haz the power, 2016-02-10 23:11:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1688433005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1688433005/1

[commit-bot: I haz the power, 2016-02-10 23:15:54]

Description was changed from

==========
Revert of  Clean up public interface of AttachmentBrokerUnprivileged. (patchset
#4 id:80001 of https://codereview.chromium.org/1679763002/ )

Reason for revert:
c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error
C2065: 'attachment_broker_' : undeclared identifier

http://build.chromium.org/p/chromium/builders/Win/builds/40168

Original issue's description:
> Clean up public interface of AttachmentBrokerUnprivileged.
> 
> In the old interface, a static factory method returns a scoped_ptr, and the
> caller had to manage the lifetime. Since this is a global object with minimal
> memory footprint, and is required to outlive every IPC::Channel, it's much
> easier for the global to never be destroyed. This also matches the interface
for
> AttachmentBrokerPrivileged.
> 
> BUG=584297

TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584297
==========

to

==========
Revert of  Clean up public interface of AttachmentBrokerUnprivileged. (patchset
#4 id:80001 of https://codereview.chromium.org/1679763002/ )

Reason for revert:
c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error
C2065: 'attachment_broker_' : undeclared identifier

http://build.chromium.org/p/chromium/builders/Win/builds/40168

Original issue's description:
> Clean up public interface of AttachmentBrokerUnprivileged.
> 
> In the old interface, a static factory method returns a scoped_ptr, and the
> caller had to manage the lifetime. Since this is a global object with minimal
> memory footprint, and is required to outlive every IPC::Channel, it's much
> easier for the global to never be destroyed. This also matches the interface
for
> AttachmentBrokerPrivileged.
> 
> BUG=584297

TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584297
==========

[commit-bot: I haz the power, 2016-02-10 23:16:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-16 22:32:16]

Description was changed from

==========
Revert of  Clean up public interface of AttachmentBrokerUnprivileged. (patchset
#4 id:80001 of https://codereview.chromium.org/1679763002/ )

Reason for revert:
c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error
C2065: 'attachment_broker_' : undeclared identifier

http://build.chromium.org/p/chromium/builders/Win/builds/40168

Original issue's description:
> Clean up public interface of AttachmentBrokerUnprivileged.
> 
> In the old interface, a static factory method returns a scoped_ptr, and the
> caller had to manage the lifetime. Since this is a global object with minimal
> memory footprint, and is required to outlive every IPC::Channel, it's much
> easier for the global to never be destroyed. This also matches the interface
for
> AttachmentBrokerPrivileged.
> 
> BUG=584297

TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584297
==========

to

==========
Revert of  Clean up public interface of AttachmentBrokerUnprivileged. (patchset
#4 id:80001 of https://codereview.chromium.org/1679763002/ )

Reason for revert:
c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error
C2065: 'attachment_broker_' : undeclared identifier

http://build.chromium.org/p/chromium/builders/Win/builds/40168

Original issue's description:
> Clean up public interface of AttachmentBrokerUnprivileged.
>
> In the old interface, a static factory method returns a scoped_ptr, and the
> caller had to manage the lifetime. Since this is a global object with minimal
> memory footprint, and is required to outlive every IPC::Channel, it's much
> easier for the global to never be destroyed. This also matches the interface
for
> AttachmentBrokerPrivileged.
>
> BUG=584297

TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584297

Committed: https://crrev.com/4a1261e7d45256df422494a8f94289dfb57a5dbf
Cr-Commit-Position: refs/heads/master@{#374771}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:16]

Patchset 1 (id:??) landed as
https://crrev.com/4a1261e7d45256df422494a8f94289dfb57a5dbf
Cr-Commit-Position: refs/heads/master@{#374771}