Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168843002: use SkColorType instead of SkBitmap::Config in views/effects (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

use SkColorType instead of SkBitmap::Config in views/effects TBR=scroggo Committed: http://code.google.com/p/skia/source/detail?r=13469

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -124 lines) Patch
include/views/SkWindow.h View 2 chunks +3 lines, -3 lines 0 comments Download
samplecode/SampleApp.cpp View 4 chunks +12 lines, -45 lines 0 comments Download
src/effects/SkAlphaThresholdFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/effects/SkBicubicImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
src/effects/SkBlurImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
src/effects/SkBlurMaskFilter.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
src/effects/SkDisplacementMapEffect.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/effects/SkLayerRasterizer.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
src/effects/SkLightingImageFilter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/effects/SkMagnifierImageFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/effects/SkMatrixConvolutionImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
src/effects/SkMorphologyImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
src/effects/SkTransparentShader.cpp View 1 5 chunks +10 lines, -12 lines 0 comments Download
src/effects/gradients/SkGradientShader.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
src/utils/SkCanvasStateUtils.cpp View 1 2 3 2 chunks +13 lines, -14 lines 0 comments Download
src/utils/mac/SkCreateCGImageRef.cpp View 1 2 chunks +10 lines, -11 lines 0 comments Download
src/views/SkWidgets.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
src/views/SkWindow.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
src/views/mac/SkNSView.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
6 years, 10 months ago (2014-02-16 04:02:20 UTC) #1
reed1
lgtm
6 years, 10 months ago (2014-02-16 20:59:28 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-16 20:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/168843002/190001
6 years, 10 months ago (2014-02-16 20:59:44 UTC) #4
commit-bot: I haz the power
Change committed as 13469
6 years, 10 months ago (2014-02-16 22:03:48 UTC) #5
scroggo
6 years, 10 months ago (2014-02-17 15:03:32 UTC) #6
Message was sent while issue was closed. 
On 2014/02/16 22:03:48, I haz the power (commit-bot) wrote:
> Change committed as 13469

lgtm

Powered by Google App Engine
This is Rietveld 408576698