Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1688423002: Fix status files to account for dart_product runtime. (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix status files to account for dart_product runtime. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/64a5845d19c6f394903cfdd9fd5d194300bf527a

Patch Set 1 #

Patch Set 2 : address-self-review #

Patch Set 3 : self-code-review #

Patch Set 4 : self-review-comments #

Total comments: 2

Patch Set 5 : code-review-comments #

Patch Set 6 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -144 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 5 6 chunks +14 lines, -16 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 5 chunks +30 lines, -38 lines 0 comments Download
M tests/isolate/isolate.status View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language.status View 7 chunks +31 lines, -23 lines 0 comments Download
M tests/lib/lib.status View 5 chunks +11 lines, -11 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 7 chunks +54 lines, -49 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years, 10 months ago (2016-02-12 03:30:19 UTC) #2
siva
4 years, 10 months ago (2016-02-12 17:43:53 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/1688423002/diff/60001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://chromiumcodereview.appspot.com/1688423002/diff/60001/tests/co19/co19-runtime.status#newcode6 tests/co19/co19-runtime.status:6: [ ($runtime == vm || $runtime == dart_precompiled ...
4 years, 10 months ago (2016-02-16 19:16:21 UTC) #4
siva
https://chromiumcodereview.appspot.com/1688423002/diff/60001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://chromiumcodereview.appspot.com/1688423002/diff/60001/tests/co19/co19-runtime.status#newcode6 tests/co19/co19-runtime.status:6: [ ($runtime == vm || $runtime == dart_precompiled || ...
4 years, 10 months ago (2016-02-17 17:12:52 UTC) #5
siva
4 years, 10 months ago (2016-02-17 20:22:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
64a5845d19c6f394903cfdd9fd5d194300bf527a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698