Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: src/ppc/builtins-ppc.cc

Issue 1688373002: PPC: [Interpreter] Save and restore dispatch table pointer during calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ppc/builtins-ppc.cc
diff --git a/src/ppc/builtins-ppc.cc b/src/ppc/builtins-ppc.cc
index b03cf5f5dcdbaa189915802c50030bce91193125..09f99ef77e6ef4584e214e97161e265516ba304b 100644
--- a/src/ppc/builtins-ppc.cc
+++ b/src/ppc/builtins-ppc.cc
@@ -977,15 +977,12 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
FrameScope frame_scope(masm, StackFrame::MANUAL);
__ PushFixedFrame(r4);
__ addi(fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));
- __ push(r6);
- // Push dispatch table pointer.
- __ mov(r3, Operand(ExternalReference::interpreter_dispatch_table_address(
- masm->isolate())));
- __ push(r3);
- // Push zero for bytecode array offset.
+ // Push new.target, dispatch table pointer and zero for bytecode array offset.
__ li(r3, Operand::Zero());
- __ push(r3);
+ __ mov(r5, Operand(ExternalReference::interpreter_dispatch_table_address(
+ masm->isolate())));
+ __ Push(r6, r5, r3);
// Get the bytecode array from the function object and load the pointer to the
// first entry into kInterpreterBytecodeRegister.
@@ -1043,8 +1040,8 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
Operand(InterpreterFrameConstants::kRegisterFilePointerFromFp));
__ mov(kInterpreterBytecodeOffsetRegister,
Operand(BytecodeArray::kHeaderSize - kHeapObjectTag));
- __ lwz(kInterpreterDispatchTableRegister,
- MemOperand(fp, InterpreterFrameConstants::kDispatchTableFromFp));
+ __ LoadP(kInterpreterDispatchTableRegister,
+ MemOperand(fp, InterpreterFrameConstants::kDispatchTableFromFp));
// Dispatch to the first bytecode handler for the function.
__ lbzx(r4, MemOperand(kInterpreterBytecodeArrayRegister,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698