Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1688343002:
Fix the mis-showing of the panel window during profile switch. (Closed)
DescriptionFix the mis-showing of the panel window during profile switch.
BUG=564725
Committed: https://crrev.com/459570f1050345e11c4bd849ef06a13a789f0a77
Cr-Commit-Position: refs/heads/master@{#375073}
Patch Set 1 : #
Total comments: 1
Patch Set 2 : Address oshima@'s comment. #
Total comments: 1
Messages
Total messages: 18 (8 generated)
The CQ bit was checked by xdai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688343002/20001
Patchset #1 (id:1) has been deleted
Description was changed from ========== Fix the miss-showing of the panel window during profile switch. BUG=564725 ========== to ========== Fix the mis-showing of the panel window during profile switch. BUG=564725 ==========
xdai@chromium.org changed reviewers: + oshima@chromium.org, skuhne@chromium.org
Could you help to take a look at this CL to see if it's a proper fix please? Thanks for your help!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1688343002/diff/20001/chrome/browser/ui/ash/m... File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc (right): https://codereview.chromium.org/1688343002/diff/20001/chrome/browser/ui/ash/m... chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:634: if (window->IsVisible() == visible && window->layer()->IsDrawn()) I dug a bit more and I think the following is the right one. if (window->TargetVisibility() == visible) or if (window->layer()->GetTargetVisibility() == visible)
On 2016/02/11 23:31:56, oshima wrote: > https://codereview.chromium.org/1688343002/diff/20001/chrome/browser/ui/ash/m... > File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc > (right): > > https://codereview.chromium.org/1688343002/diff/20001/chrome/browser/ui/ash/m... > chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:634: if > (window->IsVisible() == visible && window->layer()->IsDrawn()) > I dug a bit more and I think the following is the right one. > > if (window->TargetVisibility() == visible) > > or > > if (window->layer()->GetTargetVisibility() == visible) Done. Thanks!
lgtm
lgtm https://codereview.chromium.org/1688343002/diff/40001/chrome/browser/ui/ash/m... File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc (right): https://codereview.chromium.org/1688343002/diff/40001/chrome/browser/ui/ash/m... chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:634: if (window->TargetVisibility() == visible) Oh nice! Yes, that makes sense!
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688343002/40001
Message was sent while issue was closed.
Description was changed from ========== Fix the mis-showing of the panel window during profile switch. BUG=564725 ========== to ========== Fix the mis-showing of the panel window during profile switch. BUG=564725 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix the mis-showing of the panel window during profile switch. BUG=564725 ========== to ========== Fix the mis-showing of the panel window during profile switch. BUG=564725 Committed: https://crrev.com/459570f1050345e11c4bd849ef06a13a789f0a77 Cr-Commit-Position: refs/heads/master@{#375073} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/459570f1050345e11c4bd849ef06a13a789f0a77 Cr-Commit-Position: refs/heads/master@{#375073} |
