Deleting chrome.searchEnginesPrivate API.

Deleting chrome.searchEnginesPrivate API.

BUG=588189
Committed: https://crrev.com/b33eadee0ef965e05d3fdd007bb693d67079d97e
Cr-Commit-Position: refs/heads/master@{#377720}

[dpapad, 2016-02-19 19:04:12]

Description was changed from

==========
Deleting chrome.searchEnginesPrivate API.

BUG=
==========

to

==========
Deleting chrome.searchEnginesPrivate API.

BUG=588189
==========

[dpapad, 2016-02-19 19:07:21]

Patchset #3 (id:40001) has been deleted

[dpapad, 2016-02-24 01:59:52]

Patchset #5 (id:100001) has been deleted

[dpapad, 2016-02-24 01:59:57]

Patchset #4 (id:80001) has been deleted

[dpapad, 2016-02-24 02:00:02]

Patchset #3 (id:60001) has been deleted

[dpapad, 2016-02-24 02:00:08]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-02-24 02:00:13]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-02-24 18:44:29]

dpapad@chromium.org changed reviewers:
+ mpearson@chromium.org, rdevlin.cronin@chromium.org, stevenjb@chromium.org

[dpapad, 2016-02-24 18:44:30]

The chrome.searchEnginesPrivate API was added by
https://codereview.chromium.org/1096143003 and
https://codereview.chromium.org/1109563003. I went through those CLs and tried
to revert all the related pieces.

rdevlin.cronin
 - chrome/browser/extensions/
 - chrome/common/extensions/
 - third_party/closure_compiler/externs/search_engines_private.js

stevenjb
 - chrome/browser/extensions/api/search_engines_private/

mpearson
 - extensions/browser/extension_function_histogram_value.h
 - tools/metrics/histograms/histograms.xml

@mpearson: The only change I could not revert was the "kSearchEnginePrivate"
enum value at
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/....
This file does not state any instructions on how to properly delete an entry.

[Mark P, 2016-02-24 18:50:12]

histograms.xml and extension_function_histogram_value.h lgtm

[Dan Beam, 2016-02-24 20:21:17]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-02-24 20:21:18]

third_party/closure_compiler/externs lgtm

[Devlin, 2016-02-24 23:00:22]

extensions lgtm

[dpapad, 2016-02-25 19:40:57]

On 2016/02/24 at 23:00:22, rdevlin.cronin wrote:
> extensions lgtm

@stevenjb: Friendly ping.

[stevenjb, 2016-02-25 20:10:52]

Sorry, I didn't realize you needed me for an owner.

I still think this is unfortunate, but RS LGTM,

[dpapad, 2016-02-25 22:03:54]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-02-25 22:15:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1688333002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1688333002/140001

[commit-bot: I haz the power, 2016-02-26 00:13:27]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-02-26 00:14:31]

Description was changed from

==========
Deleting chrome.searchEnginesPrivate API.

BUG=588189
==========

to

==========
Deleting chrome.searchEnginesPrivate API.

BUG=588189

Committed: https://crrev.com/b33eadee0ef965e05d3fdd007bb693d67079d97e
Cr-Commit-Position: refs/heads/master@{#377720}
==========

[commit-bot: I haz the power, 2016-02-26 00:14:33]

Patchset 2 (id:??) landed as
https://crrev.com/b33eadee0ef965e05d3fdd007bb693d67079d97e
Cr-Commit-Position: refs/heads/master@{#377720}