Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1688333002: Deleting chrome.searchEnginesPrivate API. (Closed)

Created:
4 years, 10 months ago by dpapad
Modified:
4 years, 10 months ago
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, extensions-reviews_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@manage_search_engines_ui1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deleting chrome.searchEnginesPrivate API. BUG=588189 Committed: https://crrev.com/b33eadee0ef965e05d3fdd007bb693d67079d97e Cr-Commit-Position: refs/heads/master@{#377720}

Patch Set 1 : Rebase #

Patch Set 2 : Update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1284 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_api.h View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_api.cc View 1 chunk +0 lines, -340 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_apitest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_event_router.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_event_router.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_event_router_factory.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/api/search_engines_private/search_engines_private_event_router_factory.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/search_engines_private.idl View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/api_test/search_engines_private/main.html View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/api_test/search_engines_private/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/search_engines_private/test.js View 1 chunk +0 lines, -121 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 2 chunks +7 lines, -7 lines 0 comments Download
D third_party/closure_compiler/externs/search_engines_private.js View 1 chunk +0 lines, -123 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
dpapad
The chrome.searchEnginesPrivate API was added by https://codereview.chromium.org/1096143003 and https://codereview.chromium.org/1109563003. I went through those CLs and ...
4 years, 10 months ago (2016-02-24 18:44:30 UTC) #9
Mark P
histograms.xml and extension_function_histogram_value.h lgtm
4 years, 10 months ago (2016-02-24 18:50:12 UTC) #10
Dan Beam
third_party/closure_compiler/externs lgtm
4 years, 10 months ago (2016-02-24 20:21:18 UTC) #12
Devlin
extensions lgtm
4 years, 10 months ago (2016-02-24 23:00:22 UTC) #13
dpapad
On 2016/02/24 at 23:00:22, rdevlin.cronin wrote: > extensions lgtm @stevenjb: Friendly ping.
4 years, 10 months ago (2016-02-25 19:40:57 UTC) #14
stevenjb
Sorry, I didn't realize you needed me for an owner. I still think this is ...
4 years, 10 months ago (2016-02-25 20:10:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688333002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688333002/140001
4 years, 10 months ago (2016-02-25 22:15:19 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 10 months ago (2016-02-26 00:13:27 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 00:14:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b33eadee0ef965e05d3fdd007bb693d67079d97e
Cr-Commit-Position: refs/heads/master@{#377720}

Powered by Google App Engine
This is Rietveld 408576698