Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168833004: [sync] Fix sync tests for Android. (Closed)

Created:
6 years, 10 months ago by nyquist
Modified:
6 years, 10 months ago
Reviewers:
shashi
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

[sync] Fix sync tests for Android. This fixes and re-enables all the host driven sync tests. NOTRY=true BUG=329757, 309997, 311091 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M chrome/android/host_driven_tests/SyncTest.py View 1 chunk +6 lines, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/testshell/javatests/AndroidManifest.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
nyquist
shashishekhar: PTAL
6 years, 10 months ago (2014-02-18 21:56:07 UTC) #1
shashi
lgtm
6 years, 10 months ago (2014-02-18 22:02:56 UTC) #2
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 10 months ago (2014-02-19 02:51:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/168833004/1
6 years, 10 months ago (2014-02-19 02:51:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 03:48:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 03:48:20 UTC) #6
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 10 months ago (2014-02-19 07:56:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/168833004/1
6 years, 10 months ago (2014-02-19 07:57:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 07:57:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 07:57:38 UTC) #10
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 10 months ago (2014-02-19 08:04:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/168833004/1
6 years, 10 months ago (2014-02-19 08:05:05 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 08:05:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 08:05:30 UTC) #14
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 10 months ago (2014-02-19 15:22:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/168833004/1
6 years, 10 months ago (2014-02-19 15:22:56 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 15:23:17 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 15:23:18 UTC) #18
nyquist
skipping try-jobs since the issue is bot-related, not the CL specifically. Also see https://codereview.chromium.org/171773007/ for ...
6 years, 10 months ago (2014-02-20 00:55:11 UTC) #19
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 10 months ago (2014-02-20 00:55:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/168833004/1
6 years, 10 months ago (2014-02-20 01:41:29 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 02:02:39 UTC) #22
Message was sent while issue was closed. 
Change committed as 252154

Powered by Google App Engine
This is Rietveld 408576698