Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168833003: Remove uses of PlatformFile from leveldb (Closed)

Created:
6 years, 10 months ago by rvargas (doing something else)
Modified:
6 years, 10 months ago
Reviewers:
kinuko, dgrogan
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -155 lines) Patch
M content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/leveldatabase/env_chromium.h View 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 11 chunks +72 lines, -88 lines 0 comments Download
M third_party/leveldatabase/env_chromium_stdio.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium_stdio.cc View 6 chunks +21 lines, -23 lines 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/leveldatabase/env_chromium_win.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium_win.cc View 7 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rvargas (doing something else)
PTAL. kinuko: leveldb dgrogan: content
6 years, 10 months ago (2014-02-18 23:11:18 UTC) #1
dgrogan
lgtm Can you run env_chromium_unittests locally? The bots don't run it.
6 years, 10 months ago (2014-02-18 23:39:19 UTC) #2
rvargas (doing something else)
On 2014/02/18 23:39:19, dgrogan wrote: > lgtm > > Can you run env_chromium_unittests locally? The ...
6 years, 10 months ago (2014-02-19 00:07:57 UTC) #3
kinuko
lgtm
6 years, 10 months ago (2014-02-19 06:28:20 UTC) #4
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 10 months ago (2014-02-19 14:56:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/168833003/40001
6 years, 10 months ago (2014-02-19 15:08:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/168833003/40001
6 years, 10 months ago (2014-02-19 15:37:33 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 21:09:05 UTC) #8
Message was sent while issue was closed. 
Change committed as 252089

Powered by Google App Engine
This is Rietveld 408576698