Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 168833002: call clear() instead of using deprecated API accessBitmap() (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
f(malita), bsalomon, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

call clear() instead of using deprecated API accessBitmap() BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251778

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
reed1
6 years, 10 months ago (2014-02-16 03:32:12 UTC) #1
reed1
I think the win failures are unrelated to this CL.
6 years, 10 months ago (2014-02-16 20:25:46 UTC) #2
reed1
6 years, 10 months ago (2014-02-18 13:58:12 UTC) #3
bsalomon
On 2014/02/18 13:58:12, reed1 wrote: lgtm
6 years, 10 months ago (2014-02-18 14:02:38 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-18 14:08:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 14:08:15 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-18 14:08:15 UTC) #7
reed1
lgtm
6 years, 10 months ago (2014-02-18 14:08:44 UTC) #8
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-18 14:08:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/168833002/120001
6 years, 10 months ago (2014-02-18 14:08:56 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:40:59 UTC) #11
Message was sent while issue was closed.
Change committed as 251778

Powered by Google App Engine
This is Rietveld 408576698