Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 1688283003: [Interpreter] Implements calls through CallICStub in the interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes comments I missed in last patch. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index c4351b497764ba4a9915f29c3e1c70afe5d5abb8..68fdc4a2b09cd77422c7565f8d87adf601c73f08 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -164,8 +164,17 @@ class BytecodeArrayBuilder final : public ZoneObject, private RegisterMover {
// |callable|, the receiver should be in |receiver_args| and all subsequent
// arguments should be in registers <receiver_args + 1> to
// <receiver_args + receiver_arg_count - 1>.
+ // Call through CallICStub to get Typefeedback.
+ BytecodeArrayBuilder& CallIC(Register callable, Register receiver_args,
+ size_t receiver_arg_count, int feedback_slot);
+
+ // Call a JS function. The JSFunction or Callable to be called should be in
+ // |callable|, the receiver should be in |receiver_args| and all subsequent
+ // arguments should be in registers <receiver_args + 1> to
+ // <receiver_args + receiver_arg_count - 1>.
+ // Call without type feedback for eval and calls from lookup slots.
BytecodeArrayBuilder& Call(Register callable, Register receiver_args,
- size_t receiver_arg_count, int feedback_slot);
+ size_t receiver_arg_count);
// Call the new operator. The |constructor| register is followed by
// |arg_count| consecutive registers containing arguments to be

Powered by Google App Engine
This is Rietveld 408576698