Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: test/cctest/interpreter/test-interpreter.cc

Issue 1688283003: [Interpreter] Implements calls through CallICStub in the interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips port contributed by balazs.kilvady. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-interpreter.cc
diff --git a/test/cctest/interpreter/test-interpreter.cc b/test/cctest/interpreter/test-interpreter.cc
index 69cf0e18bd48dfa507f248e563083519be77c5d0..21c0fcf3e2fd54e7c68a42121a85303066648678 100644
--- a/test/cctest/interpreter/test-interpreter.cc
+++ b/test/cctest/interpreter/test-interpreter.cc
@@ -936,10 +936,12 @@ static void TestInterpreterCall(TailCallMode tail_call_mode) {
i::FeedbackVectorSpec feedback_spec(&zone);
i::FeedbackVectorSlot slot = feedback_spec.AddLoadICSlot();
+ i::FeedbackVectorSlot call_slot = feedback_spec.AddCallICSlot();
Handle<i::TypeFeedbackVector> vector =
i::NewTypeFeedbackVector(isolate, &feedback_spec);
int slot_index = vector->GetIndex(slot);
+ int call_slot_index = vector->GetIndex(call_slot);
Handle<i::String> name = factory->NewStringFromAsciiChecked("func");
name = factory->string_table()->LookupString(isolate, name);
@@ -950,7 +952,9 @@ static void TestInterpreterCall(TailCallMode tail_call_mode) {
0, 1);
builder.LoadNamedProperty(builder.Parameter(0), name, slot_index)
.StoreAccumulatorInRegister(Register(0))
- .Call(Register(0), builder.Parameter(0), 1, 0, tail_call_mode)
+ .Call(Register(0), builder.Parameter(0), 1, tail_call_mode)
+ .CallIC(Register(0), builder.Parameter(0), 1, call_slot_index,
+ tail_call_mode)
rmcilroy 2016/02/22 12:53:23 You are doing Call and CallIC, but only checking t
mythria 2016/02/22 14:51:32 I am sorry, I thought I will revisit this when reb
.Return();
Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
@@ -969,7 +973,9 @@ static void TestInterpreterCall(TailCallMode tail_call_mode) {
0, 1);
builder.LoadNamedProperty(builder.Parameter(0), name, slot_index)
.StoreAccumulatorInRegister(Register(0))
- .Call(Register(0), builder.Parameter(0), 1, 0, tail_call_mode)
+ .Call(Register(0), builder.Parameter(0), 1, tail_call_mode)
+ .CallIC(Register(0), builder.Parameter(0), 1, call_slot_index,
+ tail_call_mode)
.Return();
Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
@@ -997,7 +1003,8 @@ static void TestInterpreterCall(TailCallMode tail_call_mode) {
.StoreAccumulatorInRegister(Register(2))
.LoadLiteral(Smi::FromInt(11))
.StoreAccumulatorInRegister(Register(3))
- .Call(Register(0), Register(1), 3, 0, tail_call_mode)
+ .Call(Register(0), Register(1), 3, tail_call_mode)
+ .CallIC(Register(0), Register(1), 3, call_slot_index, tail_call_mode)
.Return();
Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
@@ -1040,7 +1047,8 @@ static void TestInterpreterCall(TailCallMode tail_call_mode) {
.StoreAccumulatorInRegister(Register(10))
.LoadLiteral(factory->NewStringFromAsciiChecked("j"))
.StoreAccumulatorInRegister(Register(11))
- .Call(Register(0), Register(1), 11, 0, tail_call_mode)
+ .Call(Register(0), Register(1), 11, tail_call_mode)
+ .CallIC(Register(0), Register(1), 11, call_slot_index, tail_call_mode)
.Return();
Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();

Powered by Google App Engine
This is Rietveld 408576698