Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
index 0e90c6fc8ade495e43691bbd839fd7d124e2daa5..b199a031fec20038829ebf4ab99731c9ccb27864 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
@@ -121,7 +121,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {
/**
* @param {!WebInspector.DebuggerModel.Location} rawLocation
- * @param {function(!WebInspector.UILocation):(boolean|undefined)} updateDelegate
+ * @param {function(!WebInspector.LiveLocation)} updateDelegate
* @return {!WebInspector.DebuggerWorkspaceBinding.Location}
*/
createLiveLocation: function(rawLocation, updateDelegate)
@@ -135,7 +135,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {
/**
* @param {!WebInspector.DebuggerModel.CallFrame} callFrame
- * @param {function(!WebInspector.UILocation):(boolean|undefined)} updateDelegate
+ * @param {function(!WebInspector.LiveLocation)} updateDelegate
* @return {!WebInspector.DebuggerWorkspaceBinding.Location}
*/
createCallFrameLiveLocation: function(callFrame, updateDelegate)
@@ -469,7 +469,7 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo.prototype = {
},
/**
- * @param {!WebInspector.LiveLocation} location
+ * @param {!WebInspector.DebuggerWorkspaceBinding.Location} location
*/
_addLocation: function(location)
{
@@ -478,7 +478,7 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo.prototype = {
},
/**
- * @param {!WebInspector.LiveLocation} location
+ * @param {!WebInspector.DebuggerWorkspaceBinding.Location} location
*/
_removeLocation: function(location)
{
@@ -512,7 +512,7 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo.prototype = {
* @param {!WebInspector.Script} script
* @param {!WebInspector.DebuggerModel.Location} rawLocation
* @param {!WebInspector.DebuggerWorkspaceBinding} binding
- * @param {function(!WebInspector.UILocation):(boolean|undefined)} updateDelegate
+ * @param {function(!WebInspector.LiveLocation)} updateDelegate
*/
WebInspector.DebuggerWorkspaceBinding.Location = function(script, rawLocation, binding, updateDelegate)
{
@@ -530,7 +530,8 @@ WebInspector.DebuggerWorkspaceBinding.Location.prototype = {
uiLocation: function()
{
var debuggerModelLocation = this._rawLocation;
- return this._binding.rawLocationToUILocation(debuggerModelLocation);
+ var uiLocation = this._binding.rawLocationToUILocation(debuggerModelLocation);
+ return uiLocation;
dgozman 2016/02/18 02:42:50 nit: please revert
kozy 2016/02/18 02:55:44 Done.
},
dispose: function()

Powered by Google App Engine
This is Rietveld 408576698