 Chromium Code Reviews
 Chromium Code Reviews Issue 1688283002:
  [DevTools] Blackboxing in LiveLocations is supported in Linkifier  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
    
  
    Issue 1688283002:
  [DevTools] Blackboxing in LiveLocations is supported in Linkifier  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3| Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js | 
| diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js | 
| index f7804d5f9db3f8d8b37512ad054f2f7183ad390f..0cde3ff287caf2c02e5f5ebee114e7bdbd553541 100644 | 
| --- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js | 
| +++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js | 
| @@ -202,16 +202,7 @@ WebInspector.Linkifier.prototype = { | 
| // FIXME(62725): console stack trace line/column numbers are one-based. | 
| var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0; | 
| var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0; | 
| - var anchor = this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, classes); | 
| - var debuggerModel = WebInspector.DebuggerModel.fromTarget(target); | 
| - var location = debuggerModel && debuggerModel.createRawLocationByScriptId(callFrame.scriptId, callFrame.lineNumber, callFrame.columnNumber); | 
| - var blackboxed = location ? | 
| - WebInspector.blackboxManager.isBlackboxedRawLocation(location) : | 
| - WebInspector.blackboxManager.isBlackboxedURL(callFrame.url); | 
| - if (blackboxed) | 
| - anchor.classList.add("webkit-html-blackbox-link"); | 
| - | 
| - return anchor; | 
| + return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, classes); | 
| }, | 
| /** | 
| @@ -336,6 +327,11 @@ WebInspector.Linkifier.DefaultFormatter.prototype = { | 
| if (typeof uiLocation.lineNumber === "number") | 
| titleText += ":" + (uiLocation.lineNumber + 1); | 
| anchor.title = titleText; | 
| + | 
| + if (uiLocation.isBlackboxed) | 
| + anchor.classList.add("webkit-html-blackbox-link"); | 
| 
dgozman
2016/02/17 22:46:22
classList.toggle(...)
 
kozy
2016/02/18 01:52:25
This update can be called if blackboxed state wasn
 | 
| + else | 
| + anchor.classList.remove("webkit-html-blackbox-link"); | 
| } | 
| } |