Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 */ 166 */
167 WebInspector.PresentationConsoleMessage = function(message, rawLocation) 167 WebInspector.PresentationConsoleMessage = function(message, rawLocation)
168 { 168 {
169 this._text = message.messageText; 169 this._text = message.messageText;
170 this._level = message.level === WebInspector.ConsoleMessage.MessageLevel.Err or ? WebInspector.UISourceCode.Message.Level.Error : WebInspector.UISourceCode.M essage.Level.Warning; 170 this._level = message.level === WebInspector.ConsoleMessage.MessageLevel.Err or ? WebInspector.UISourceCode.Message.Level.Error : WebInspector.UISourceCode.M essage.Level.Warning;
171 this._liveLocation = WebInspector.debuggerWorkspaceBinding.createLiveLocatio n(rawLocation, this._updateLocation.bind(this)); 171 this._liveLocation = WebInspector.debuggerWorkspaceBinding.createLiveLocatio n(rawLocation, this._updateLocation.bind(this));
172 } 172 }
173 173
174 WebInspector.PresentationConsoleMessage.prototype = { 174 WebInspector.PresentationConsoleMessage.prototype = {
175 /** 175 /**
176 * @param {!WebInspector.UILocation} uiLocation 176 * @param {!WebInspector.LiveLocation} liveLocation
177 */ 177 */
178 _updateLocation: function(uiLocation) 178 _updateLocation: function(liveLocation)
179 { 179 {
180 if (this._uiMessage) 180 if (this._uiMessage)
181 this._uiMessage.remove(); 181 this._uiMessage.remove();
182 var uiLocation = liveLocation.uiLocation();
183 if (!uiLocation)
184 return;
182 this._uiMessage = uiLocation.uiSourceCode.addLineMessage(this._level, th is._text, uiLocation.lineNumber, uiLocation.columnNumber); 185 this._uiMessage = uiLocation.uiSourceCode.addLineMessage(this._level, th is._text, uiLocation.lineNumber, uiLocation.columnNumber);
183 }, 186 },
184 187
185 dispose: function() 188 dispose: function()
186 { 189 {
187 this._liveLocation.dispose(); 190 this._liveLocation.dispose();
188 if (this._uiMessage) 191 if (this._uiMessage)
189 this._uiMessage.remove(); 192 this._uiMessage.remove();
190 } 193 }
191 } 194 }
192 195
193 /** @type {!WebInspector.PresentationConsoleMessageHelper} */ 196 /** @type {!WebInspector.PresentationConsoleMessageHelper} */
194 WebInspector.presentationConsoleMessageHelper; 197 WebInspector.presentationConsoleMessageHelper;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698