Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1688253003:
Ensure WebLocalFrame parameters match. (Closed)
|
Created:
4 years, 10 months ago by Avi (use Gerrit) Modified:
4 years, 10 months ago Reviewers:
nasko CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure WebLocalFrame parameters match.
BUG=361765
TEST=no whammies
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
Committed: https://crrev.com/aa13a92c9640f16f50c001deaa61c791d700bc45
Cr-Commit-Position: refs/heads/master@{#375380}
Patch Set 1 #Patch Set 2 : logging #Patch Set 3 : drop a few #Patch Set 4 : no commentary #Messages
Total messages: 25 (14 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688253003/1
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688253003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== An experiment to see how redundant those WebLocalFrame parameters really are. BUG=361765 ========== to ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies ==========
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688253003/40001
Description was changed from ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies ========== to ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel ==========
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688253003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688253003/60001
avi@chromium.org changed reviewers: + nasko@chromium.org
LGTM
The CQ bit was unchecked by avi@chromium.org
The CQ bit was checked by avi@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688253003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688253003/60001
Message was sent while issue was closed.
Description was changed from ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel ========== to ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel ========== to ========== Ensure WebLocalFrame parameters match. BUG=361765 TEST=no whammies CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel Committed: https://crrev.com/aa13a92c9640f16f50c001deaa61c791d700bc45 Cr-Commit-Position: refs/heads/master@{#375380} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/aa13a92c9640f16f50c001deaa61c791d700bc45 Cr-Commit-Position: refs/heads/master@{#375380} |
