Fix crash with --load-extension for extensions with plugins

Fix crash with --load-extension for extensions with plugins

Ensure the extension install UI has a profile available to use for image loading, even if the prompt is opened before any browser window are available.

This bug is currently crashing Clusterfuzz ~100 times per hour and polluting the crash statistics.

BUG=344199
TEST=see bug
TBR=miket@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252077

[James Cook, 2014-02-18 23:59:06]

mek, PTAL

This may not be a particularly elegant fix but we kinda need to get the crash
reporter pollution under control.

[Marijn Kruisselbrink, 2014-02-19 00:16:13]

On 2014/02/18 23:59:06, James Cook wrote:
> mek, PTAL
> 
> This may not be a particularly elegant fix but we kinda need to get the crash
> reporter pollution under control.

I don't think the "There is no profile available at this point" is correct,
further up in the callstack tehre is ExtensionSystemImpl::InitForRegularProfile
which does have a valid profile, so there is a profile, it just somehow isn't
passed on to the install prompt. But as a stop-gap, this lgtm.

[James Cook, 2014-02-19 00:58:04]

mek, PTAL - this seems like a better fix.  In particular, it's bad to create an
ExtensionInstallPrompt that has no associated profile.

[Marijn Kruisselbrink, 2014-02-19 00:59:51]

On 2014/02/19 00:58:04, James Cook wrote:
> mek, PTAL - this seems like a better fix.  In particular, it's bad to create
an
> ExtensionInstallPrompt that has no associated profile.
yes, I agree, this seems like a much better fix. LGTM

[James Cook, 2014-02-19 01:04:30]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-02-19 01:07:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/168823004/60001

[commit-bot: I haz the power, 2014-02-19 02:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 02:54:47]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[James Cook, 2014-02-19 18:28:04]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-02-19 18:37:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/168823004/260001

[commit-bot: I haz the power, 2014-02-19 20:57:59]

Change committed as 252077