Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688183002: Include suppressed dialogs in the FineTiming histogram (Closed)

Created:
4 years, 10 months ago by Joe Mason
Modified:
4 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include suppressed dialogs in the FineTiming histogram Committed: https://crrev.com/505f421d0a73adae4f74924b3022996c731de40e Cr-Commit-Position: refs/heads/master@{#374920}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M components/app_modal/javascript_app_modal_dialog.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/app_modal/javascript_app_modal_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/app_modal/javascript_dialog_manager.cc View 1 chunk +15 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Joe Mason
PTAL. This is a followup to crrev.com/1638013002
4 years, 10 months ago (2016-02-11 14:43:58 UTC) #2
Avi (use Gerrit)
lgtm https://codereview.chromium.org/1688183002/diff/1/components/app_modal/javascript_dialog_manager.cc File components/app_modal/javascript_dialog_manager.cc (right): https://codereview.chromium.org/1688183002/diff/1/components/app_modal/javascript_dialog_manager.cc#newcode110 components/app_modal/javascript_dialog_manager.cc:110: // page is doing something very hinky. Wellll... ...
4 years, 10 months ago (2016-02-11 15:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688183002/1
4 years, 10 months ago (2016-02-11 17:55:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 19:29:00 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:36:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/505f421d0a73adae4f74924b3022996c731de40e
Cr-Commit-Position: refs/heads/master@{#374920}

Powered by Google App Engine
This is Rietveld 408576698