Remove unused or unneeded stuff from java_core.dart.

Remove unused or unneeded stuff from java_core.dart.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/b0719aa402fad3af6bee26f6519cd5a696e57e06

[Bob Nystrom, 2016-02-11 23:15:51]

rnystrom@google.com changed reviewers:
+ brianwilkerson@google.com

[Bob Nystrom, 2016-02-11 23:15:51]

I just removed the lowest-hanging fruit: stuff that was completely unused or
barely used.

At some point, it would be good to get rid of the custom exception types that
mirror ones in the Dart core library, but I didn't do that here since it might
be a breaking change.

[Brian Wilkerson, 2016-02-12 15:50:34]

Other than the two methods still in use, LGTM

https://codereview.chromium.org/1688113004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/java_core.dart (left):

https://codereview.chromium.org/1688113004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/java_core.dart:18: String format(String pattern,
'format' is used in analysis_server, so it can't be removed yet.

https://codereview.chromium.org/1688113004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/java_core.dart:239: static int makeHashCode(List
a) {
'makeHashCode' is used in analysis_server

[Bob Nystrom, 2016-02-12 19:10:51]

Description was changed from

==========
Remove unused or unneeded stuff from java_core.dart.
==========

to

==========
Remove unused or unneeded stuff from java_core.dart.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b0719aa402fad3af6bee26f6519cd5a696e57e06
==========

[Bob Nystrom, 2016-02-12 19:10:52]

Committed patchset #2 (id:20001) manually as
b0719aa402fad3af6bee26f6519cd5a696e57e06 (presubmit successful).

[Bob Nystrom, 2016-02-12 19:11:21]

https://codereview.chromium.org/1688113004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/java_core.dart (left):

https://codereview.chromium.org/1688113004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/java_core.dart:18: String format(String pattern,
On 2016/02/12 15:50:33, Brian Wilkerson wrote:
> 'format' is used in analysis_server, so it can't be removed yet.

Done.

https://codereview.chromium.org/1688113004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/java_core.dart:239: static int makeHashCode(List
a) {
On 2016/02/12 15:50:33, Brian Wilkerson wrote:
> 'makeHashCode' is used in analysis_server

Done.